vr: restart conntrackd instead of '/usr/sbin/conntrackd -d' by weizhouapache · Pull Request #5275 · apache/cloudstack

weizhouapache · 2021-08-04T07:49:46Z

Description

This PR fixes #5138

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2021-08-04T07:50:08Z

@blueorangutan package

blueorangutan · 2021-08-04T07:51:05Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-08-04T08:33:40Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 749

weizhouapache · 2021-08-04T09:02:14Z

@blueorangutan test

blueorangutan · 2021-08-04T09:03:03Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2021-08-04T11:28:13Z

systemvm/debian/opt/cloud/bin/cs/CsRedundant.py

@@ -280,7 +280,7 @@ def set_backup(self):
            dev = interface.get_device()

        cmd = "%s -C %s" % (self.CONNTRACKD_BIN, self.CONNTRACKD_CONF)


@weizhouapache if cmd is unused can we remove it?

@rhtyd sure...

blueorangutan · 2021-08-05T00:21:32Z

Trillian test result (tid-1474)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53252 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5275-t1474-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 83 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	213.43	test_privategw_acl.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Failure`	311.32	test_routers_network_ops.py
test_04_nonsecured_to_secured_vm_migration	`Error`	8.31	test_vm_life_cycle.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	437.01	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	476.01	test_vpc_redundant.py

weizhouapache · 2021-08-05T07:08:49Z

@blueorangutan test

blueorangutan · 2021-08-05T07:09:02Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2021-08-05T07:18:04Z

systemvm/debian/opt/cloud/bin/cs/CsRedundant.py

            CsHelper.execute("ifconfig %s down" % interface.get_device())

-        cmd = "%s -C %s" % (self.CONNTRACKD_BIN, self.CONNTRACKD_CONF)
        CsHelper.execute("%s -s" % cmd)


@weizhouapache wrong cmd was removed?

@rhtyd
sorry, fixed now

yadvr · 2021-08-05T07:18:45Z

@weizhouapache everytime any code is changed, pl kick bo package before kicking testing

blueorangutan · 2021-08-05T07:57:21Z

Trillian Build Failed (tid-1484)

This reverts commit b97cf469952fe0706d91af411eaffa62a06761a6.

weizhouapache · 2021-08-05T19:14:44Z

@blueorangutan package

blueorangutan · 2021-08-05T19:15:03Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-08-05T19:49:23Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 768

weizhouapache · 2021-08-05T21:53:25Z

@blueorangutan test

blueorangutan · 2021-08-05T21:54:04Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2021-08-06T12:32:46Z

@blueorangutan test

blueorangutan · 2021-08-06T12:33:02Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-08-06T12:49:22Z

Trillian test result (tid-1503)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52042 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5275-t1503-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	3609.97	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	98.04	test_kubernetes_clusters.py

nvazquez

LGTM

vr: restart conntrackd instead of '/usr/sbin/conntrackd -d'

db0f6c0

weizhouapache closed this Aug 4, 2021

weizhouapache reopened this Aug 4, 2021

yadvr added this to the 4.15.2.0 milestone Aug 4, 2021

yadvr approved these changes Aug 4, 2021

View reviewed changes

yadvr reviewed Aug 4, 2021

View reviewed changes

vr: remove unused cmd

7c43bd1

weizhouapache closed this Aug 5, 2021

weizhouapache reopened this Aug 5, 2021

yadvr reviewed Aug 5, 2021

View reviewed changes

weizhouapache added 2 commits August 5, 2021 20:11

Revert "vr: remove unused cmd"

764ee29

This reverts commit b97cf469952fe0706d91af411eaffa62a06761a6.

vr: remove unused cmd

5150c86

yadvr approved these changes Aug 6, 2021

View reviewed changes

nvazquez approved these changes Aug 7, 2021

View reviewed changes

apache deleted a comment from blueorangutan Aug 9, 2021

yadvr merged commit 05d1d56 into apache:4.15 Aug 9, 2021

yadvr mentioned this pull request Aug 9, 2021

conntrackd failed in VPC with Redundant VRs (4.15.1.0) #5138

Closed

weizhouapache deleted the 4.15-restart-conntrackd-instead-daemon-start branch December 9, 2022 08:45

		@@ -280,7 +280,7 @@ def set_backup(self):
		dev = interface.get_device()

		cmd = "%s -C %s" % (self.CONNTRACKD_BIN, self.CONNTRACKD_CONF)

Conversation

weizhouapache commented Aug 4, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Aug 4, 2021

Uh oh!

blueorangutan commented Aug 4, 2021

Uh oh!

blueorangutan commented Aug 4, 2021

Uh oh!

weizhouapache commented Aug 4, 2021

Uh oh!

blueorangutan commented Aug 4, 2021

Uh oh!

yadvr Aug 4, 2021

Choose a reason for hiding this comment

Uh oh!

weizhouapache Aug 4, 2021

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Aug 5, 2021

Uh oh!

weizhouapache commented Aug 5, 2021

Uh oh!

blueorangutan commented Aug 5, 2021

Uh oh!

yadvr Aug 5, 2021

Choose a reason for hiding this comment

Uh oh!

weizhouapache Aug 5, 2021

Choose a reason for hiding this comment

Uh oh!

yadvr commented Aug 5, 2021

Uh oh!

blueorangutan commented Aug 5, 2021

Uh oh!

weizhouapache commented Aug 5, 2021

Uh oh!

blueorangutan commented Aug 5, 2021

Uh oh!

blueorangutan commented Aug 5, 2021

Uh oh!

weizhouapache commented Aug 5, 2021

Uh oh!

blueorangutan commented Aug 5, 2021

Uh oh!

yadvr commented Aug 6, 2021

Uh oh!

blueorangutan commented Aug 6, 2021

Uh oh!

blueorangutan commented Aug 6, 2021

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants